CLDR-17316 cldr-apps-webdriver add Dashboard test, etc #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-New SurveyDriverDashboard.java implements TEST_DASHBOARD -Add scripts/selenium-server-4.16.1.jar for convenience -Configure pom.xml to use spotless formatter, same as cldr-apps -Partially reformat (defer complete reformatting to subsequent PR) -Partially update SurveyDriverXMLUploader.java per Survey Tool changes -Turn off logging of 4444/status json, too noisy -For the fast voting test (CLDR-17248), add scripts/cldrHarStats.mjs; generates summary (average post/get times) and html table (details) -Comments
srl295
approved these changes
Jan 25, 2024
| @@ -61,10 +60,11 @@ public class SurveyDriver { | |||
| * Enable/disable specific tests using these booleans | |||
There was a problem hiding this comment.
would it make sense for these to be in a properties or json file?
There was a problem hiding this comment.
yes, there's already a surveydriver.properties which so far only has the password in it
|
|
||
| private static final String[] locales = { | ||
| // Czech, German, Spanish, French, Hindi, Japanese, Russian, Chinese | ||
| "cs", "de", "es", "fr", "hi", "ja", "ru", "zh" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-New SurveyDriverDashboard.java implements TEST_DASHBOARD
-Add scripts/selenium-server-4.16.1.jar for convenience
-Configure pom.xml to use spotless formatter, same as cldr-apps
-Partially reformat (defer complete reformatting to subsequent PR)
-Partially update SurveyDriverXMLUploader.java per Survey Tool changes
-Turn off logging of 4444/status json, too noisy
-For the fast voting test (CLDR-17248), add scripts/cldrHarStats.mjs; generates summary (average post/get times) and html table (details)
-Comments